#26022 closed Cleanup/optimization (fixed)
Use the context manager version of assertRaises decorators where appropriate
Reported by: | Hasan Ramezani | Owned by: | Hasan Ramezani |
---|---|---|---|
Component: | Testing framework | Version: | dev |
Severity: | Normal | Keywords: | |
Cc: | Triage Stage: | Accepted | |
Has patch: | yes | Needs documentation: | no |
Needs tests: | no | Patch needs improvement: | yes |
Easy pickings: | no | UI/UX: | no |
Description
rewrite below django admin register decorator test in context manager version:
- test_wrapped_class_not_a_model_admin
- test_custom_site_not_an_admin_site
Change History (8)
comment:1 Changed 8 years ago by
Component: | Uncategorized → Testing framework |
---|---|
Owner: | changed from nobody to Hasan Ramezani |
Status: | new → assigned |
comment:2 Changed 8 years ago by
Has patch: | set |
---|
comment:3 Changed 8 years ago by
Patch needs improvement: | set |
---|---|
Summary: | rewrite django admin register decorator some test → Use the context manager version of assertRaises decorators where appropriate |
Triage Stage: | Unreviewed → Accepted |
Version: | 1.9 → master |
As noted on the pull request, a more comprehensive cleanup would be appreciated.
comment:7 Changed 8 years ago by
Resolution: | → fixed |
---|---|
Status: | assigned → closed |
Note: See
TracTickets for help on using
tickets.
Pull request: https://github.com/django/django/pull/5995