Changes between Initial Version and Version 1 of Ticket #26007, comment 3


Ignore:
Timestamp:
Dec 30, 2015, 12:07:37 PM (8 years ago)
Author:
Chris Cogdon

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #26007, comment 3

    initial v1  
    33In the current code, if both template_name and template_field_name is set, template_field_name is always ignored. With the patch, if template_field_name is declared AND there is a non-empty value in the referenced field, the template name from the field is used in preference to template_name.
    44
    5 I think the patch implements the intended behaviour (or why bother trying to `insert(0, name)`), and cases were someone has set both template_name and template_field_name is rare or non-existant, but given this possibility, we may want to defer the change to 1.10 with or without accelerated deprecation. Advise?
     5I think the patch implements the intended behaviour (or why bother trying to `insert(0, name)`, and compare the implementation in `MultipleObjectTemplateResponseMixin.get_template_names`), and cases were someone has set both template_name and template_field_name is rare or non-existant, but given this possibility, we may want to defer the change to 1.10 with or without accelerated deprecation. Advise?
Back to Top