Changes between Initial Version and Version 1 of Ticket #25980, comment 7
- Timestamp:
- Dec 24, 2015, 9:44:19 AM (8 years ago)
Legend:
- Unmodified
- Added
- Removed
- Modified
-
Ticket #25980, comment 7
initial v1 1 [https://github.com/django/django/pull/5873 Here] is a PR that adds a test that verifies that the ModelMultipleChoiceField can handle querysets when cleaning, because this is what happens when the field is disabled and has a queryset as initial value, see [https://github.com/django/django/blob/d91cc25a2a43cb2526943dc2285ffe59e38fabfd/django/forms/forms.py#L372 code]. I still don't know whether this properly reflects the intended behaviour.1 [https://github.com/django/django/pull/5873 Here] is a PR that adds a failing test that verifies that the ModelMultipleChoiceField can handle querysets when cleaning, because this is what happens when the field is disabled and has a queryset as initial value, see [https://github.com/django/django/blob/d91cc25a2a43cb2526943dc2285ffe59e38fabfd/django/forms/forms.py#L372 code]. I still don't know whether this properly reflects the intended behaviour. 2 2 3 3 The test might be "too small" to properly explain my problem, as it tests only the field, not the form... let me know if i should add another test.