GEOSGEometry handles srid parameter differently for EWKB and EWKT input

[Sergey Fedoseev]

In [14]: pnt = Point(1, 1, srid=4326)

In [15]: print GEOSGeometry(pnt.ewkt, srid=1)
SRID=4326;POINT (1.0000000000000000 1.0000000000000000)

In [16]: print GEOSGeometry(pnt.ewkb, srid=1)
SRID=1;POINT (1.0000000000000000 1.0000000000000000)

It's not clear from documentation what is the correct behavior, in my opinion srid parameter should be used as default SRID i.e. only if input geometry input does not include SRID.

[Jani Tiainen]

I think it's really ambiguous to let same thing to be defined in two places, specially when explicit SRID is given. If that value would be implicit then using as a default would be fine.

One may think that resulting geometry does have SRID set to srid parameter (and possibly transformation has taken place).

I think raisin error would be proper action here if SRIDs don't match since programmer must know at this point that geometry is in some specific format. It would give at least surprise to everybody.

[Sergey Fedoseev]

​PR

[Tim Graham <timograham@…>]

In 6ecccad:

Fixed #25873 -- Made GEOSGeometry handle the srid parameter more predictably.