Changes between Initial Version and Version 1 of Ticket #25741, comment 5


Ignore:
Timestamp:
Nov 12, 2015, 3:06:44 PM (8 years ago)
Author:
Ramez Issac

Legend:

Unmodified
Added
Removed
Modified

  • Ticket #25741, comment 5

    initial v1  
    1 Either add it to the Feed class in `Feed.__call__()` , or later on in `Feed.get_feed()`
    2 If that is not convenient for some reason (@alexmorozov care to elaborate on thread safe part, How this wont be thread safe?! I'm not an expert in this area)
     1~~Either add it to the Feed class in `Feed.__call__()` , or later on in `Feed.get_feed()`
     2If that is not convenient for some reason (@alexmorozov care to elaborate on thread safe part, How this wont be thread safe?! I'm not an expert in this area)~~ Got it, `request` is a class attribute in our case.
    33
    4 The next best thing is to send it as a parameter but this road is long, bumpy and not backward compatible.
     4Another option is to send `request` as a parameter.. not a big fan of that road.
     5
     6
Back to Top