Add support for SCRIPT_NAME in STATIC_URL and MEDIA_URL

[Dheerendra Rathor]

By default, {% static '...' %} tag just appends STATIC_URL in the path. When running on sub-path, using SCRIPT_NAME WSGI param, it results in incorrect static URL - it doesn't prepend SCRIPT_NAME prefix.

This problem can be solved with prepending SCRIPT_NAME to STATIC_URL in settings.py but that doesn't work when SCRIPT_NAME is a dynamic value.

This can be easily added into default Django static tag and django.contrib.staticfiles tag as following:

def render(self, context):
    url = self.url(context)
    # Updating url here with request.META['SCRIPT_NAME'] 
    if self.varname is None:
        return url
    context[self.varname] = url
        return ''

On more research I found that FileSystemStorage and StaticFilesStorage ignores SCRIPT_NAME as well.

We might have to do a lot of changes but I think it's worth the efforts.

[Tim Graham]

This change doesn't seem correct to me (for one, it seems like it could break existing sites). Why not include the appropriate prefix in your STATIC_URL and MEDIA_URL settings?

[Dheerendra Rathor]

This is not a patch. This is just an idea I got about the patch for {% static %} only. The patch will (probably) involve FileSystemStorage and StaticFileSystemStorage classes.

The main idea behind this feature was that Django will auto detect script_name header and use that accordingly for creating static and media urls. This will reduce human efforts for setting up sites in future. This patch will also take time to develop so it can be added in Django2.0 timeline.

[Tim Graham]

What I meant was that I don't think Django should automatically use SCRIPT_NAME in generating those URLs. If you're running your site on a subpath, then you should set your STATIC_URL to '​http://example.com/subpath/static/' or whatever. However, you might not even be hosting static and uploaded files on the same domain as your site (in fact, for user-uploaded files, you shouldn't do that ​for security reasons) in which case SCRIPT_URL is irrelevant in constructing the static/media URLs.

How would the change make it easier to setup sites?

[Claude Paroz]

I think that the idea basically makes sense. Ideally, a Django instance shouldn't need to know at which subpath it is being deployed, as this can be considered as purely sysadmin stuff. It would be a good separation of concerns. For example, the Web administrator may change the WSGIScriptAlias from /foo to /bar and the application should continue working. Of course, this only applies when *_URL settings are not full URIs.

In practice, it's very likely that many running instances are adapting their *_URL settings to include the base script path, hence the behavior change would be backwards incompatible. The question is whether the change is worth the incompatibility.

[Tim Graham]

I see. I guess the idea would be to use get_script_prefix() like reverse() does as I don't think we have access to request everywhere we need it. It seems like some public APIs like get_static_url() and get_media_url() would replace accessing the settings directly whenever building URLs. For backwards compatibility, possibly these functions could try to detect if the setting is already prefixed appropriately.

Removing the prefix from the settings, however, means that the URLs are no longer correct when generated outside of a request/response cycle though (#16734). I'm not sure if it might create any practical problems, but we might think about addressing that issue first.

[Rostyslav Bryzgunov]

I'm here at DjangoCon US 2016 will try to create a patch for this ticket ;)

[Rostyslav Bryzgunov]

Pull-request created: ​https://github.com/django/django/pull/7000

[Tim Graham]

At least documentation and additional tests look like they are required.

[Rostyslav Bryzgunov]

Absolutely agree with your remarks, Tim. I'll add tests. Could you point to docs that need to be updated?

[Joel Dunham]

I would like to take this ticket on and have a new PR for it: ​https://github.com/django/django/pull/10724

[Oleg Kainov]

I tried to revive activities around this ticket, so I created (yet another) PR based on previous work ​https://github.com/django/django/pull/11564

[Mariusz Felisiak <felisiak.mariusz@…>]

In c574bec:

Fixed #25598 -- Added SCRIPT_NAME prefix to STATIC_URL and MEDIA_URL set to relative paths.

Thanks Florian Apolloner for reviews.

Co-authored-by: Joel Dunham <Joel.Dunham@…>

[Mariusz Felisiak <felisiak.mariusz@…>]

In 9d05add:

Fixed #32394 -- Changed project template settings to use relative STATIC_URL.

Refs #25598 which added original support for relative STATIC_URL and
MEDIA_URL.