Opened 9 years ago
Last modified 9 years ago
#25445 closed Cleanup/optimization
`AttributeError` when `app_config` is missing attribute `models_module` in contenttypes/management.py — at Version 3
Description (last modified by ) ¶
if not app_config.models_module: return
The return statement is never reached since if app_config
doesn't have a models_module
attribute it raises an AttributeError
.
Regardless of whether to allow the return statement to catch or return an AttributeError
, this code should perhaps be changed to be more clear. I suggest either raising an AttributeError
explicitly or using gettattr
.
Change History (3)
comment:1 by , 9 years ago
Summary: | `AttributeError` when `app_config` is missing attribute `models_module` in contenttypes/mananagent.py → `AttributeError` when `app_config` is missing attribute `models_module` in contenttypes/management.py |
---|
comment:2 by , 9 years ago
Owner: | changed from | to
---|---|
Status: | new → assigned |
comment:3 by , 9 years ago
Description: | modified (diff) |
---|
Note:
See TracTickets
for help on using tickets.