Pass application list to more admin views

[rm_]

Pass the list of available applications to more views so it is possible to show a menu with them.

Discussion on list:
​https://groups.google.com/forum/#!searchin/django-developers/having$20the$20app/django-developers/SLwh7zJmkTQ/RPUABdNYuCIJ

[rm_]

Pull request:
​https://github.com/django/django/pull/4410

[Tim Graham]

It might be a use case for AdminSite.each_context(). Could we merely add the AdminSite.get_app_list() method (called build_app_list() in your patch) and allow users to override AdminSite.each_context() if they want that available in all their contexts?

[rm_]

Replying to timgraham:

It might be a use case for AdminSite.each_context(). Could we merely add the AdminSite.get_app_list() method (called build_app_list() in your patch) and allow users to override AdminSite.each_context() if they want that available in all their contexts?

My plan is to consume this data on django theme and really much like to have it work out of the box without requiring user intervention. If that's not possible i'll go with the each_context() route.

Settings needs better patch because some tests are failing.

[rm_]

Tests passes, the docs test not passing i think is not related to the patchset as in some runs it did pass. One thing i am wondering about is to don't call build_app_list() if is_popup() is true since it does not make much sense to add it inside a popup. Flipping the needs improvement bits to get some review exposure. What do you think?

[Tim Graham <timograham@…>]

In bd53db5:

Fixed #24553 -- Added the list of available applications to AdminSite.each_context()

[Tim Graham]

Reopening due to test failures reported in #24798.

[rm_]

Opened pull request here:
​https://github.com/django/django/pull/4659

[Tim Graham <timograham@…>]

In adf5d75a:

Refs #24553 -- Isolated admin_* tests.

This fixes a regression with runtests.py --reverse after
bd53db5eab05099ae371348529c6428e0da95c6a

We need to avoid leaking model registration in the default AdminSite.

[Tim Graham]

Still seeing two test failures with $ ./runtests.py auth_tests

[rm_]

Looking into this, it looks like all the test without custom AdminSite leaks auth models in the site breaking the two test classes using custom ROOT_URLCONF that are failing.

UPDATE: actually it does not, for some reason we are not able to do the reverse for app_list with app_label auth but if i dump the content of site.get_urls() i have <RegexURLPattern app_list ^(?P<app_label>auth)/$>. So running out of ideas :|

[Tim Graham]

There appears to be leakage of the URLs from tests/auth_tests/urls.py into tests that use ROOT_URLCONF='auth_tests.test_urls_admin'. Couldn't find the reason for this but traced it as far as ​RegexURLResolver.urlconf_module which shows leakage with this version:

    @property
    def urlconf_module(self):
        if isinstance(self.urlconf_name, six.string_types):
            module = import_module(self.urlconf_name)
            patterns = getattr(module, "urlpatterns")
            print('---- %s ---- %s ' % (self.urlconf_name, patterns))
            return module
        else:
            return self.urlconf_name

and:

$ ./tests/runtests.py auth_tests.test_views.ChangePasswordTest.test_password_change_fails_with_invalid_old_password auth_tests.test_views.ChangelistTests.test_user_change_password

While the second test is executing, you'll see the URLs from the first test.

Because the default admin site is leaking into the second test, its logout view is being called (AdminSite.name is 'admin' instead of 'auth_test_admin').

[rm_]

Got it! PR here ​https://github.com/django/django/pull/4675

[Tim Graham <timograham@…>]

In ae1efb8:

Refs #24553 -- Fixed urlpatterns leakage in auth_tests