Changes between Initial Version and Version 2 of Ticket #23780


Ignore:
Timestamp:
Nov 25, 2014, 9:36:03 PM (9 years ago)
Author:
Brian Faherty
Comment:

Legend:

Unmodified
Added
Removed
Modified

  • Ticket #23780 – Description

    initial v2  
    1 Having to implement two methods on two different objects in order to use natural keys is very cumbersome. I would think we could implement something on a models meta to take a tuple of field names for use in both the natural_key and get_by_natural_key methods. I implemented this in a way that would be overridable to keep compatible with the current methods but would allow for easy use in the future. Working code with this is here https://github.com/scrummyin/django/commit/7e562127c3a9610ae3ad9fab6855a005f4d4706f. Includes 6 more tests around a two new methods, with same name but on the model and manager. Sll old tests are still working with minimal changes. The minimal change is to use a new method to check for a natural_key instead of hasattr.
     1Having to implement two methods on two different objects in order to use natural keys is very cumbersome. I would think we could implement something on a models meta to take a tuple of field names for use in both the natural_key and get_by_natural_key methods. I implemented this in a way that would be overridable to keep compatible with the current methods but would allow for easy use in the future. Working code with this is here https://github.com/scrummyin/django/commit/7e562127c3a9610ae3ad9fab6855a005f4d4706f. Includes 6 more tests around a two new methods, with same name but on the model and manager. The old tests are still working with minimal changes. The minimal change is to use a new method to check for a natural_key instead of hasattr. The pull request branch has all
Back to Top