Changes between Initial Version and Version 3 of Ticket #23761


Ignore:
Timestamp:
Nov 4, 2014, 9:05:46 PM (10 years ago)
Author:
Adam DePue
Comment:

Legend:

Unmodified
Added
Removed
Modified

  • Ticket #23761

    • Property Component Uncategorized → Core (System checks)
    • Property Easy pickings set

  • Ticket #23761 – Description

    initial v3  
    22https://github.com/django/django/commit/e9103402c0fa873aea58a6a11dba510cd308cb84#diff-14
    33
    4 The fix contains a lot more than is needed for this specific issue, however the specific changes to django/db/backends/mysql/validation.py would be great to have in Django 1.7
     4The fix contains a lot more than is needed for this specific issue, however the specific changes to django/db/backends/mysql/validation.py would be great to have in Django 1.7.
    55
    6 The issue is that if you create a custom field that returns None for db_type(), then it causes crashes due to dereference None to check the startswith().
     6When implementing a custom field type with a db_type() method that returns None, on Django 1.6 and below we would signify not to create a column at all.
     7With Django 1.7, this causes a crash with the mysql backend.
     8The issue is already fixed in master and this simply backports the safety check.
    79
    810This worked fine in < Django 1.7 and works fine in upstream.
Back to Top