Add kwargs support for cursor.callproc()

[fatal10110]

I think it will be useful to add kwargs or args parameters to callproc method for those backends that support more parameters for callproc method (e.g cx_oracle)

I can not use named parameters for my procedures with django db module. =

[Aymeric Augustin]

​PEP 249 says that callproc only accept positional arguments.

That said, since we're just forwarding arguments to the underlying library, this small deviation seems acceptable, with a comment explaining it.

[averybigant]

pull request created
​https://github.com/django/django/pull/3342
already tested on ubuntu 12.04 server(amd64) with oracle XE 11g

[Shai Berger]

Thanks for the patch. I'll take a look at it tonight (UTC+3)

[Shai Berger]

Hi,

I made some notes on the PR. Additionally, documentation needed. I suggested making the feature more general, less Oracle-specific, but even if this path is not taken, the new behavior needs to be documented. Currently, callproc is not documented at all, which is a shame, but forgivable considering that the function is as defined in PEP 249; deviating from the PEP justifies adding explicit documentation, probably in docs/topics/db/sql.txt; whether or not that is done, the addition should be mentioned in the release notes (docs/releases/1.8.txt).

[averybigant]

Replying to shaib:

Hi,

I made some notes on the PR. Additionally, documentation needed. I suggested making the feature more general, less Oracle-specific, but even if this path is not taken, the new behavior needs to be documented. Currently, callproc is not documented at all, which is a shame, but forgivable considering that the function is as defined in PEP 249; deviating from the PEP justifies adding explicit documentation, probably in docs/topics/db/sql.txt; whether or not that is done, the addition should be mentioned in the release notes (docs/releases/1.8.txt).

Thanks for your detailed comments. New commit pushed. I also replied your comments on github.

[Michael Manfre]

Implementation needs a DatabaseFeature (e.g. callproc_supports_kwargs to explicitly enable support for kparams for a backend. The current patch will pass along kparams to the underlying backend as long as they are provided to callproc, which will raise a confusing exception to the user. It should probably raise NotSupportedError.

[averybigant]

Replying to manfre:

Implementation needs a DatabaseFeature (e.g. callproc_supports_kwargs) to explicitly enable support for kparams for a backend. The current patch will pass along kparams to the underlying backend as long as they are provided to callproc, which will raise a confusing exception to the user. It should probably raise django.db.utils.NotSupportedError.

Thanks. Made the changes you suggested.

[Shai Berger]

I've added some Notes on the PR, and opened a related ​mailing list discussion.

[theromulanz]

Is this patch still being considered for release?
I have the same use-case as the ticket description(cx_Oracle keywordParameters).

[Tim Graham]

If you'd like to help, please update the old pull request for the comments.

[Mariusz Felisiak]

​PR

[GitHub <noreply@…>]

In 489421b:

Fixed #23546 -- Added kwargs support for CursorWrapper.callproc() on Oracle.

Thanks Shai Berger, Tim Graham and Aymeric Augustin for reviews and
Renbi Yu for the initial patch.