FileField.url returns a wrong URL

[david.fischer.ch@…]

models.py:

...
class Media(models.Model):
    ....
    file = models.FileField(upload_to=storages.upload_to, storage=storages.media_storage)
    ...

storages.py:

...
def upload_to(instance, filename):
    return '%s/%s' % (instance.pk, filename)

media_storage = FileSystemStorage(location='/test/media', base_url='/test/media')

Django shell:

...
>>> m = Media.objects.get(pk=27)
>>> m.file.storage.base_url
'/test/media'
>>> m.file.name
'salut.txt'
>>> m.file.url
'/test/salut.txt'

Expected -> '/test/media/salut.txt'

Investigating:

>>> from django.utils.six.moves.urllib.parse import urljoin
>>> urljoin('/test/media', 'salut.txt')
'/test/salut.txt'

[david.fischer.ch@…]

Hello,

Using '/test/media/' instead of '/test/media' fix the issue.

This is an unexpected behavior, I would like that the default implementation of FileSystemStorage takes care of this.

[Claude Paroz]

PR: ​https://github.com/django/django/pull/2731

[Tim Graham]

We require MEDIA_URL to end with a trailing slash (see #6198 for reasons why it won't be changed). I am not sure if the same reasoning holds for this, but I thought it was worth mentioning.

[mardini]

urljoin() is implemented like this in Python to be consistent with RFC 3986, section 5.2.3. (​http://tools.ietf.org/html/rfc3986#section-5.2.3) which states how merging a relative-path with the base URI should work. It *might* not be a good idea to override that standard for the convince.

[Claude Paroz]

IMHO, RFC 3986 is aimed at "generic" merging, where you can't assume that /url point to a path, but can also be an arbitrary resource. In our case, base_url can be considered as a path in all cases (AFAIK), that's why I don't see the problem of auto-adding the ending slash. But if anyone can come with a use case where this is not wanted behavior, I'll happily change my mind.

[mardini]

That's a solid reasoning I guess.
I can't think of any use case where adding a trailing slash to base_url would cause undesirable behavior either. And since base_url isn't necessarily MEDIA_URL, I see no harm in implementing this feature, even though MEDIA_URL must always end in a slash.

Thanks.

[Claude Paroz <claude@…>]

In fb9d8f06520f495d0c36236f7534dbe660c7e164:

Fixed #22717 -- Auto-corrected missing ending slash in FileSystemStorage

Thanks David Fischer for the report and Moayad Mardini for the
review.