Changes between Initial Version and Version 4 of Ticket #22712


Ignore:
Timestamp:
Jan 17, 2017, 3:37:22 PM (7 years ago)
Author:
Anton Samarchyan
Comment:

Legend:

Unmodified
Added
Removed
Modified

  • Ticket #22712

    • Property Cc Richard Eames added
    • Property Triage Stage Unreviewed → Accepted
    • Property Type Uncategorized → Cleanup/optimization

  • Ticket #22712 – Description

    initial v4  
    1 Currently the staticfiles finders' `find` function has a paramter `all` which is also a built-in function. Personally, I consider using built-ins as parameters/variables to be bad form, and would usually just rename the parameter in my subclasses. Unfortunately, `find` is explicitly called with `all=all` in `django.contrib.staticfiles.finders.find()`. So, to use the built in `all()` one needs to use `from __builtin__ import all as all_`.
     1Currently the staticfiles finders' `find` function has a parameter `all` which is also a built-in function. Personally, I consider using built-ins as parameters/variables to be bad form, and would usually just rename the parameter in my subclasses. Unfortunately, `find` is explicitly called with `all=all` in `django.contrib.staticfiles.finders.find()`. So, to use the built in `all()` one needs to use `from __builtin__ import all as all_`.
    22
    33There are probably more examples throughout the codebase, but this is the one I've run into.
Back to Top