Changes between Version 4 and Version 5 of Ticket #22678, comment 2
- Timestamp:
- May 22, 2014, 4:53:39 PM (10 years ago)
Legend:
- Unmodified
- Added
- Removed
- Modified
-
Ticket #22678, comment 2
v4 v5 1 1 I intended to convey that above: the issue is the integer key. Strings work, integers don't. 2 2 The form as built 'looked' reasonable, but had a murky and hard to track problem. 3 Most code paths blow up on integers, but not this one.4 3 5 6 The proposed fix is to assert on string for the key.... or almost as good perform the string 7 concatenation (e.g. 'id_'+key) in all cases, so it blows up nice and fast with any form of key that 8 does not actually fully work. 9 4 The proposed fix is to assert on string for the key.... or almost as good perform string concatenation in all cases, so it blows up nice and fast with any form of key that does not actually fully work. 10 5 11 6 This kind of does it, subject to a future optimizer dropping the empty string: