Changes between Initial Version and Version 1 of Ticket #21798, comment 12


Ignore:
Timestamp:
03/14/2014 03:34:38 AM (18 months ago)
Author:
erikr
Comment:

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #21798, comment 12

    initial v1  
    11Eh, pressed enter too soon there. Two more notes:
    22
    3 * If we also take `default` into account this warning, I definitely agree with charettes that we should fix this. Particularly as the behaviour in combination with `default` is a lot less obvious.
     3* If we also take `default` into account with this warning, I definitely agree with charettes that we should fix this. Particularly as the behaviour in combination with `default` is a lot less obvious.
    44* There are basically two options here: we could issue a DeprecationWarning, and add a field check in the next version, or just add the field check now. We went for the latter in #20484, but that was a little more severe: that actually broke in some conditions. If I understand comment:9 correctly, charette is in favour of adding the check now - I don't feel strongly either way.
Back to Top