| 9 | | - The "FIXME" comment would have to be updated to explain this the new case with a reference to this ticket. |
| 10 | | - The current test is pretty fragile, could you rather check in QS.query if there is a join? |
| | 9 | - The "FIXME" comment would have to be updated to explain this new case with a reference to this ticket. |
| | 10 | - The current test is pretty fragile, could you rather check in QS.query if there is a join? (e.g. https://gist.github.com/10345520) |
| | 11 | - Code needs to be compatible with PY3, use `range` instead of `xrange`, or import it from `six` if you really want `xrange`. |
| | 12 | - The changes **inside** the `if`, do they do anything differently or is it just a cleanup? If it's just a cleanup, only fix the `if` **condition**, and not the **implementation**. Because right now it's pretty hard to see where the problem was from. |