Changes between Version 18 and Version 21 of Ticket #21721
- Timestamp:
- Jan 14, 2014, 4:17:19 PM (11 years ago)
Legend:
- Unmodified
- Added
- Removed
- Modified
-
Ticket #21721 – Description
v18 v21 10 10 - ~~There is a failing test in the mail library regarding encoding in the mail module. Florian seemed to know about this.~~ 11 11 - ~~There is a significant issue with signal deregistration. I've been able to ascertain that something is up in the `django.dispatch.saferef` module, but I don't have a sufficient understanding to work out what's wrong. There seems to be no test which tests this code directly and failures are thrown up at random during tests, test teardown and/or test suite teardown. They show up either as `NoneType is not callable` or as `catching classes that do not inherit from BaseException is not allowed`.~~ 12 - `U` mode has been deprecated for files. We use it in `makemessages` and in `sql`, both for management commands. It seems unnecessary in `makemessages`, in the `sql` we will have to be more careful as at present we split on `\n`, which may need to be `\r\n` on windows. However, it may well be fine anyway it probably doesn't matter if we have trailing `\r` characters on the sql statements.12 - ~~`U` mode has been deprecated for files. We use it in `makemessages` and in `sql`, both for management commands. It seems unnecessary in `makemessages`, in the `sql` we will have to be more careful as at present we split on `\n`, which may need to be `\r\n` on windows. However, it may well be fine anyway it probably doesn't matter if we have trailing `\r` characters on the sql statements.~~ 13 13 - There are quite a lot of `ResourceWarning`s thrown for unclosed files ~~(and sockets in the mail tests)~~