Changes between Initial Version and Version 15 of Ticket #21721


Ignore:
Timestamp:
Jan 12, 2014, 2:57:33 PM (10 years ago)
Author:
Marc Tamlyn
Comment:

Signals branch now merged- thanks Florian.

I've opened a PR for the HTMLParser warnings - ​https://github.com/django/django/pull/2164

I've updated the description with the current outstanding issues. There are now only two test failures, relating to loading from eggs. Everything else is warnings.

Legend:

Unmodified
Added
Removed
Modified

  • Ticket #21721

    • Property Triage Stage Unreviewed → Accepted
    • Property Cc Florian Apolloner added

  • Ticket #21721 – Description

    initial v15  
    88- Our usage of `HTMLParser` should now always specify the value of `convert_charrefs` as it's default will change in Py3.5. This is slightly problematic as Py2.7 does not have this kwarg so we can't universally apply it. Perhaps the best option is a six-like wrapper.
    99- `django.utils.module_loading. module_has_submodule` has some issues with eggs.  `sys.meta_path` is giving us `importlib` as a finder. `importlib.find_module` is deferred to `importlib.find_spec` (new in py3.4), which throws an error (`ImportError: spec missing loader`).
    10 - There is a failing test in the mail library regarding encoding in the mail module. Florian seemed to know about this.
    11 - There is a significant issue with signal deregistration. I've been able to ascertain that something is up in the `django.dispatch.saferef` module, but I don't have a sufficient understanding to work out what's wrong. There seems to be no test which tests this code directly and failures are thrown up at random during tests, test teardown and/or test suite teardown. They show up either as `NoneType is not callable` or as `catching classes that do not inherit from BaseException is not allowed`.
     10- ~~There is a failing test in the mail library regarding encoding in the mail module. Florian seemed to know about this.~~
     11- ~~There is a significant issue with signal deregistration. I've been able to ascertain that something is up in the `django.dispatch.saferef` module, but I don't have a sufficient understanding to work out what's wrong. There seems to be no test which tests this code directly and failures are thrown up at random during tests, test teardown and/or test suite teardown. They show up either as `NoneType is not callable` or as `catching classes that do not inherit from BaseException is not allowed`.~~
     12- `U` mode has been deprecated for files. We use it in `makemessages` and in `sql`, both for management commands. It seems unnecessary in `makemessages`, in the `sql` we will have to be more careful as at present we split on `\n`, which may need to be `\r\n` on windows. However, it may well be fine anyway it probably doesn't matter if we have trailing `\r` characters on the sql statements.
     13- There are quite a lot of `ResourceWarning`s thrown for unclosed files (and sockets in the mail tests)
Back to Top