Code

Changes between Initial Version and Version 1 of Ticket #2131, comment 95


Ignore:
Timestamp:
10/20/12 13:10:46 (18 months ago)
Author:
aaugustin
Comment:

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #2131, comment 95

    initial v1  
    33However, I'm not sure that merging `django-sendfile` as a contrib app is the best option. There've been several discussions about endorsing third-party applications covering common needs. If we started doing that, we could just point to https://github.com/johnsensible/django-sendfile in the documentation. 
    44 
     5EDIT: Alex noticed [https://github.com/johnsensible/django-sendfile/blob/master/sendfile/backends/mod_wsgi.py#L11 some dubious code]. We can't endorse that. 
     6 
    57NB: since #7581  was fixed, serving files through `django.views.static.serve` or with a `StreamingHttpResponse` is less inefficient (although still not recommended): the entire file content isn't loaded in memory. 
    68