Changes between Initial Version and Version 1 of Ticket #20932, comment 11
- Timestamp:
- Feb 17, 2016, 1:04:16 AM (9 years ago)
Legend:
- Unmodified
- Added
- Removed
- Modified
-
Ticket #20932, comment 11
initial v1 1 I don't try to enforce anything in [https://code.djangoproject.com/ticket/25897/ #25897], I simply want to fix the existing approach, which doesn't work as expected. I think that the developer , who coded the current approach,was intended to achieve what would be achieved if [https://code.djangoproject.com/ticket/25897, #25897] would be applied.1 I don't try to enforce anything in [https://code.djangoproject.com/ticket/25897/ #25897], I simply want to fix the existing approach, which doesn't work as expected. I think that the developer who coded the current approach was intended to achieve what would be achieved if [https://code.djangoproject.com/ticket/25897, #25897] would be applied. 2 2 Do you suggest removing all the code about contributing managers to models and simple use regular python inheritance? 3 3 I must confess I like it and I thought of it many times while examining the current approach. Python inheritance works well and it's predictable. There's some login behind current approach, which is described in [https://docs.djangoproject.com/en/dev/topics/db/managers/#custom-managers-and-model-inheritance/ documentation], but I am not sure that it worth breaking regular python mro.