Opened 11 years ago
Last modified 7 years ago
#20880 closed Cleanup/optimization
Split clone() to clone() and pre_next_op() — at Initial Version
| Reported by: | Anssi Kääriäinen | Owned by: | nobody |
|---|---|---|---|
| Component: | Database layer (models, ORM) | Version: | dev |
| Severity: | Normal | Keywords: | |
| Cc: | Triage Stage: | Accepted | |
| Has patch: | yes | Needs documentation: | no |
| Needs tests: | no | Patch needs improvement: | no |
| Easy pickings: | no | UI/UX: | no |
Description
QuerySet and Query clone() methods are doing more than just cloning, they are also doing set up for next operation, changing the class of the clone if requested, and even throwing away some attribute values.
To make the code a bit more readable the clone() the preparation for next op should be splitted away to pre_next_op() method. This also allows creating inplace querysets that work precisely like full-clone querysets (inplace queryset doesn't do cloning at all). This again allows speeding up certain internal operations (like model.save() and prefetch_related()), and also allows users to optimise heavy-to-create querysets by avoiding clone() overhead.
Patch available from https://github.com/akaariai/django/tree/splitted_clone. The inplace queryset used for Model.save_base() speeds up model.save() by about 20% for a simple m = Model.objects.get(); m.save() benchmark. There are other places where similar optimisations could be used. Prefetch speedup is tracked in ticket #20577.