Changes between Initial Version and Version 1 of Ticket #20743, comment 1
- Timestamp:
- May 18, 2014, 4:00:56 AM (10 years ago)
Legend:
- Unmodified
- Added
- Removed
- Modified
-
Ticket #20743, comment 1
initial v1 1 1 In my branch at github I've incorporated the previous work found in #13142: https://github.com/andialbrecht/django/tree/ticket_20743 2 2 3 This change uses the approach to add two new settings. I 'mthought a bit about this, but didn't found a better solution than adding new settings. However, one approach would be to group all SMTP settings using a dictionary similar to cache or database settings, but this would be a more major change.3 This change uses the approach to add two new settings. I thought a bit about this, but didn't found a better solution than adding new settings. However, one approach would be to group all SMTP settings using a dictionary similar to cache or database settings, but this would be a more major change. 4 4 5 5 In addition to the previous work I've added support for keyfile/certfile when using TLS, added a note regarding certification checks (or the lack of) in the docs and added some minimal tests. I was wondering if we could find a clever approach to test the actual use of certfile/keyfile when initializing SMTP_SSL/calling starttls without some dirty mocking of the standard library. If anyone has a suggestion I'd be happy to add such tests to this patch.