Changes between Initial Version and Version 1 of Ticket #20555, comment 2


Ignore:
Timestamp:
Jun 4, 2013, 8:08:23 AM (11 years ago)
Author:
Baptiste Mispelon

Legend:

Unmodified
Added
Removed
Modified

  • Ticket #20555, comment 2

    initial v1  
    11This seems like a useful feature to add.
    22
    3 I think the fact that `ChoiceInput.tag` mutates `self.attrs` should be fixed. I haven't looked into the problem but I don't see why this couldn't be done in ``ChoiceInput.__init__`` instead (and then your patch could be used).
     3I think the fact that `ChoiceInput.tag` mutates `self.attrs` should be fixed. I haven't looked into the problem but I don't see why this couldn't be done in `ChoiceInput.__init__` instead (and then your patch could be used).
    44
    55Regarding your patch, the idea seems sound but I think the logic of passing the id to `attrs` should be moved into a separate function so that it can be shared with `as_widget` which does the same thing.
Back to Top