using registration/logged_out.html template overrides admin logout

[tomerz@…]

Hi

I created registration/login.html and registration/logged_out.html templates to handle my site login/logout using the provided auth views login/logout. While the admin app login using admin/login.html, it logouts using registration/logged_out.html. So, having my own registration/logged_out.html overrides that of the admin app.

[wim@…]

I agree with you that this behaviour is inconsistent.

You are welcome to supply a patch, if you want to.

[Roman Gladkov]

use another template for logout in admin interface

[Roman Gladkov]

added patch, if it's right way, then I'll do documentation and translations

[Tim Graham]

While this would make things more consistent, wouldn't it be backwards incompatible?

[Ramiro Morales]

Replying to timo:

While this would make things more consistent, wouldn't it be backwards incompatible?

If the inconsistent behavior is new (e.g.introduced with 1.4 or 1.5) I'm happy to call it a bug and fix it right away just like any other bug. The sooner the better.

If the has more historical roots IMHO we can apply the same reasoning but I'm open to suggestions about how to handle the timeline.

[Kamu]

The overriding of logout/login templates was added in 1.2 Alpha in response to ticket #8933.
​https://github.com/django/django/commit/a2056919799e48f053fa16b65569fc1e8f57ebe1

[Susan Tan]

I've just applied the given attached patch. I get an error: "TemplateDoesNotExist: admin/logged_out.html" How do i fix this?

[Alexis Bellido]

Pull request here:

​https://github.com/django/django/pull/1563

[Florian Apolloner]

Closing the PR for now since it is highly backwards incompatible; without some extra shim this will be hard to get in (at least needs comments in the releasenotes).

[Alexis Bellido]

Thanks for the comment. Would you recommend me to spend some time writing that shim so that projects using the older templates locations continue to work?

[Tim Graham]

@alexisbellido Yes, some form of backwards compatibility will be needed here.

[Ryan C. Schwiebert]

I ran into this bug because it occurs in the course of following this documentation here: ​https://docs.djangoproject.com/en/1.9/topics/auth/default/#using-the-views

It's not very nice that the "happy path" outlined here in the docs runs into this bug. If the problem is going to continue to be unfixed, is there an inline warning that could go in the docs about the issue here?

[Bryan Marty]

I encountered this bug while following the documentation as well.

[Hamed Fathi]

Hello please look at this bug because it's important to solve this issue because we need admin templates and custom templates be separate and we can create different templates in registration folder.

[Mariusz Felisiak]

Hamed, feel-free to prepare a patch.

[Hamed Fathi]

Replying to felixxm:

Hamed, feel-free to prepare a patch.

Hello, well how can I do that? Can you please tell me where I should read about contributing guideline?
Thank you.

[Mariusz Felisiak]

See ​Contributing to Django.

[Hamed Fathi]

The problem is same structure of template and registration folder for admin and our own app. When we use auth admin view at default it will go to the admin template folder and registration folder and render that html file. Am I right? or it works in an other way?