Changes between Initial Version and Version 11 of Ticket #20182


Ignore:
Timestamp:
05/26/2013 09:40:46 AM (2 years ago)
Author:
aaugustin
Comment:

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #20182

    • Property Cc bmispelon@… added
    • Property Patch needs improvement unset
    • Property Needs tests unset
    • Property Needs documentation unset
    • Property Triage Stage changed from Unreviewed to Ready for checkin
  • Ticket #20182 – Description

    initial v11  
    22
    33In this function, there is a clause
    4 
     4{{{
    55    if value.lower() in ('', 'false'):
    66            value = False
    7 
     7}}}
    88I think it should be
    9 
     9{{{
    1010    if value.lower() in ('', 'false', '0'):
    1111          value = False
    12 
     12}}}
    1313Note that in admin already converts a limit_choices_to={'a__isnull': False} to a__isnull=0 when formatting a query string for lookup on the remote model. Therefore, clearly it should also handle isnull=0 correctly. Currently the lookup popup box on remote model uses __isnull=0 and does not actually filter.
    1414
    15 See the following pull request
    16 
    17 https://github.com/django/django/pull/982
    18 
    19 
    20 
    21 
     15See the following pull request: https://github.com/django/django/pull/982
Back to Top