Code

Changes between Initial Version and Version 1 of Ticket #19946, comment 2


Ignore:
Timestamp:
02/28/13 17:36:07 (14 months ago)
Author:
carljm
Comment:

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #19946, comment 2

    initial v1  
    1 I think this is actually raising a different issue which none of the proposed fixes for #19866 would address, which is that you don't get any warning that you've configured `ALLOWED_HOSTS` incorrectly until a request actually comes in; there's no warning immediately on firing up manage.py shell. This was also discussed in preparing the patch, but there were no great solutions proposed. 
     1I think this is actually raising a different issue which none of the proposed fixes for #19866 would address, which is that you don't get any warning that you've configured `ALLOWED_HOSTS` incorrectly until a request actually comes in; there's no warning immediately on firing things up. This was also discussed in preparing the patch, but there were no great solutions proposed. 
    22 
    33In general, I'm not sure this is something we can fix, because we have no way of knowing whether you've configured `ALLOWED_HOSTS` correctly or not until a request comes in with an actual `Host` header. There is one common misconfiguration case we could do something about, though: the case where you've left `ALLOWED_HOSTS` empty.