Model field option "validators" not working with ManyToManyField

[fabio@…]

# models.py

def validate_depends_on(value):
    # just raise an error, whatever the value
    raise ValidationError('Error')

class Package(models.Model):
    # ...
    depends_on = models.ManyToManyField(
        'self',
        symmetrical=False,
	related_name='required_by',
        blank=True,
        null=True,
        validators=[validate_depends_on]
        )

My custom validator is not called when saving a model instance through the admin. The same validator perfectly works with other fields. Also, removing blank and null options didn't help.

[fhahn]

test that checks if a custom validator of a m2m field gets called during form validation

[fhahn]

I've added a test that checks the behavior described by the author of the ticket.

I think part of the problem is, that m2m validation cannot be done before saving the object, because the object needs a pk before a m2m related object can be added (using .add()). But the validator could be used during form validation. If not, we should at least document that the validators kwarg does not work for ManyToManyField (the null and blank kwarg are ignored too).

[Carl Meyer]

Not immediately obvious to me whether this will be reasonably fixable or not, but if not then a documentation fix is still clearly required.

[Claude Paroz]

Same test updated to master

[ANUBHAV JOSHI]

In case of Models, we make objects like:

obj = Model1(name="myname")
obj.full_clean()
obj.save()
obj.m2m_field.add(objs)

So in case of Models, calling full_clean() will definitely not run validators for M2M.
So for the case of Models, we should update the docs that validators for M2M do not work, but as Florian(fhahn) says that validators could be used in case of forms, I too am of the same opinion because in case of forms, when we provide the entire data all at once, we can surely run the validators on it when full_clean() on ModelForm is called, for which I have attached a patch.

[ANUBHAV JOSHI]

Regarding the kwargs null and blank. They do not seem to be meaningful in case of M2M as if either is null then there is actually no relation, so it should be mentioned in the docs.

[loic84]

Proposed patch from Anubhav tries to reuse ManyToManyField.validators at the form level and I don't think we should do that: model field validators are for model validation only.

It was proposed on IRC to make obj.m2m.add() use the validators, but that's conflicting with the design decision that model validation should be completely optional.

Regarding null it obviously has no meaning on a M2M since there is no corresponding field on the model. For blank I'm pretty sure that model validation would completely ignore it as checking it would require an additional query; however, model forms and admin might, so it's worth double checking.

I'm leaning towards a docs patch, and possibly system checks.

[ANUBHAV JOSHI]

​https://github.com/django/django/pull/2898

[Tim Graham <timograham@…>]

In 011abb7d96c75f6154c15a8a0f997d8c27698679:

Fixed #19671 -- Added warnings that null and validators are ignored for ManyToManyField.

Thanks Loic Bistuer and Tim Graham for help and review.