Code

Changes between Initial Version and Version 1 of Ticket #19414, comment 8


Ignore:
Timestamp:
01/29/13 02:47:33 (18 months ago)
Author:
stavros
Comment:

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #19414, comment 8

    initial v1  
    11Much better! I would not have added the "Unsupported arguments" check if I wrote it, just because someone might want to construct a dict with extra stuff and pass it (plus, ignoring kwargs isn't bad for you), but otherwise it looks great to me. 
    22 
    3 Can someone official chime in? This looks like a very good pull request. 
     3Can someone official chime in? This pull request looks very good.