Opened 3 years ago

Closed 3 years ago

Last modified 2 years ago

#19014 closed Uncategorized (duplicate)

PASSWORD_HASHERS missed in "Full list of settings"

Reported by: jedie Owned by: nobody
Component: Documentation Version: 1.4
Severity: Normal Keywords:
Cc: Triage Stage: Accepted
Has patch: no Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: no UI/UX: no

Description

PASSWORD_HASHERS not in the list of settings, here:
https://docs.djangoproject.com/en/dev/ref/settings/

Change History (4)

comment:1 Changed 3 years ago by timo

  • Needs documentation unset
  • Needs tests unset
  • Patch needs improvement unset
  • Triage Stage changed from Unreviewed to Accepted

comment:2 Changed 3 years ago by aaugustin

  • Resolution set to duplicate
  • Status changed from new to closed

Settings from contrib apps generally aren't included in the core settings list. (Some of them are for historical reasons.)

This ticket is actually a small subset of #14633. IMHO making the change for just one setting isn't going to improve the overall picture.

Last edited 3 years ago by aaugustin (previous) (diff)

comment:3 Changed 2 years ago by ramiro

Oops, I've commited a fix for this (with backports to 1.5.x and 1.4.x).

This is the comment I posted to GitHub:

Oh sorry for not searching Trac and thanks for your work on this ticket.

I've found about this while trying to learn about the 1.3.->1.4->1.5 migration path and I've read one thread in the last week related to this (i.e. this is affecting users in the real world).

I can undo the commit easily but OTOH I think it's better to it documented and don't block on a theoretical future doc refactoring.

Also, w/ this we have dummy :setting:PASSWORD_HASHERS in other parts of the docs.

And we already have another django.contrib.auth setting (PASSWORD_RESET_TIMEOUT_DAYS) just below it.

Version 0, edited 2 years ago by ramiro (next)

comment:4 Changed 2 years ago by timo

I'm not against adding this (I originally accepted this ticket ;-)). I'll try to look at the settings reorganization soon.

Note: See TracTickets for help on using tickets.
Back to Top