Changes between Initial Version and Version 5 of Ticket #18826


Ignore:
Timestamp:
10/13/2012 06:56:27 AM (3 years ago)
Author:
lrekucki
Comment:

I mainly meant things like:

  • 8 spaces of indentation;
  • very long line ending with a comment;
  • initializing cookie to an object while it's later assigned a string;
  • not initializing value of i in the loop while initializing a j with list length for a premature optimization.

Changing to === is ok, while hoisting all the variables to the top, IMHO, actually makes the code less readable (but it's probably a matter of taste).

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #18826

    • Property Status changed from new to closed
    • Property Cc lrekucki@… added
    • Property Patch needs improvement unset
    • Property Needs tests unset
    • Property Needs documentation unset
    • Property Has patch unset
    • Property Resolution changed from to worksforme
    • Property Triage Stage changed from Unreviewed to Design decision needed
  • Ticket #18826 – Description

    initial v5  
    22and as I can't sleep well if my JS doesn't pass some of the basic JSlint standards I've changed the snippet a bit:
    33{{{
     4#!javascript +line-numbers
    45jQuery(document).ajaxSend(function (event, xhr, settings) {
    56        function getCookie(name) {
Back to Top