Changes between Initial Version and Version 1 of Ticket #18727


Ignore:
Timestamp:
Aug 6, 2012, 4:00:27 PM (12 years ago)
Author:
Aymeric Augustin
Comment:

Legend:

Unmodified
Added
Removed
Modified

  • Ticket #18727 – Description

    initial v1  
    11We have copied this module from the standard library and submitted the patch to Python's bug tracker six years ago: http://bugs.python.org/issue1521051
    22
    3 Patching our copy to support both Python 2 and 3 increases severely the amount of changes from Python's version. It becomes much harder to apply upstream changes.
     3Unfortunately the ticket is stuck because the patch didn't include tests. Even if tests were added and the patch was committed now, we'd have to deprecate all Pythons <= 3.3 before removing our copy and relying on the stdlib. This isn't going to happen in the next five years.
    44
    5 Unfortunately the ticket is stuck, because the patch we provided didn't include tests. Even if tests were added and the patch was committed now, we'd have to deprecate all Pythons <= 3.3 before removing our copy and relying on the stdlib. This isn't going to happen in the next five years.
     5Patching our copy to support both Python 2 and 3 increases severely the amount of changes from Python's version. It becomes much harder to apply upstream changes. We could copy both the version from 2.7 and the version from 3.2, apply the patch to both, and import the right one, but that adds complexity.
    66
    7 Since Django moved away from using doctests, and as suggested by Russell two years ago in the tickets comments, we should deprecate our copy.
     7I think we'd better deprecate our copy:
     8- doctests aren't a suitable tool for testing Django apps (IMO),
     9- we moved away from using doctests in Django's test suite,
     10- Russell suggested it two years ago in the tickets comments.
Back to Top