Changes between Initial Version and Version 1 of Ticket #18404, comment 6


Ignore:
Timestamp:
Nov 5, 2012, 6:22:40 PM (12 years ago)
Author:
Łukasz Rekucki

Legend:

Unmodified
Added
Removed
Modified

  • Ticket #18404, comment 6

    initial v1  
    1818}}}
    1919
    20 So this is definitly a bug in FileSystemStorage.
     20So this is definitly a bug. Most likely FileSystemStorage should accept only unicode locations and AppStaticStorage should pass a unicode path as done in the patch. It would also be good is `path` didn't confuse `UnicodeDecodeError` with `ValueError` raised by `safe_join`. Maybe `safe_join` could raise a more meaningful subclass of `ValueError` instead?
    2121
    2222Note that on master (1.5) this will fail earlier (i.e. on every `os.path.join`), because of `unicode_literals` switch.
Back to Top