Changes between Initial Version and Version 2 of Ticket #18394


Ignore:
Timestamp:
May 8, 2016, 4:55:56 PM (8 years ago)
Author:
Tim Graham
Comment:

Claude, I know made some improvements when you created the new JavaScriptCatalog class-based view in 1.10. Is this ticket still relevant for that view?

Legend:

Unmodified
Added
Removed
Modified

  • Ticket #18394

    • Property Component Documentation → Internationalization
    • Property Triage Stage Unreviewed → Accepted
    • Property Cc Claude Paroz added

  • Ticket #18394 – Description

    initial v2  
    1 The ``javascript_catalog`` i18n view's ``packages`` argument only accepts modules which are either ``django.conf`` or which are also in ``INSTALLED_APPS``. But there are two issues with this:
     1The `javascript_catalog` i18n view's `packages` argument only accepts modules which are either `django.conf` or which are also in `INSTALLED_APPS`. But there are two issues with this:
    22
    3 1. The documentation for the view hides this a bit, and can create the impression that the restriction only applies to a ``packages`` argument passed through the URL.
     31. The documentation for the view hides this a bit, and can create the impression that the restriction only applies to a `packages` argument passed through the URL.
    44
    5 2. The view itself does not give you any warning if you're violating this restriction; it just silently discards anything in ``packages`` that doesn't meet the requirements.
     52. The view itself does not give you any warning if you're violating this restriction; it just silently discards anything in `packages` that doesn't meet the requirements.
    66
    7 At the very least, the documentation should be more up-front that this requirement always applies no matter how you're passing ``packages`` to the view. Possibly as a bonus, the view should warn that it's discarding any packages that don't conform to the requirements, to aid in debugging.
     7At the very least, the documentation should be more up-front that this requirement always applies no matter how you're passing `packages` to the view. Possibly as a bonus, the view should warn that it's discarding any packages that don't conform to the requirements, to aid in debugging.
Back to Top