Changes between Initial Version and Version 1 of Ticket #18135, comment 3


Ignore:
Timestamp:
04/16/2012 11:40:52 AM (3 years ago)
Author:
akaariai
Comment:

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #18135, comment 3

    initial v1  
    99}}}
    1010seems to need some way to close the connection. I am not sure if it is safe to just have a "finally: close connection" in there. Maybe it should be checked that if there is no existing connection when entering this function, but there is one when leaving it, then close the created connection.
     11
     12EDIT: reading further it seems the only usage for the version in this part of the code is checking for pre-5.0.3 versions, and as support for those versions is going to be dropped, it seems it might be possible that 1.5 does not need any other fix here than removing the get_server_version() call altogether.
Back to Top