Changes between Initial Version and Version 1 of Ticket #18135, comment 27


Ignore:
Timestamp:
Feb 18, 2013, 1:52:05 PM (12 years ago)
Author:
Aymeric Augustin

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #18135, comment 27

    initial v1  
    1010I missed a use case in my previous comment: it's possible to have a MySQL database that's only occasionally hit by workers, especially if it isn't the primary database. Such a database could support fewer simultaneous connections than the total amount of workers.
    1111
    12 In the current codebase, the only place that uses the MySQL server version is `sequence_reset_by_name_sql`, and this function is only used by the tests. It appears that it was called at import time in previous versions of Django, but that isn't true any longer.
     12In the current codebase, the only place that uses the MySQL server version is `sequence_reset_by_name_sql`, and this function is only used by the tests. It appears that `mysql_version` was called at import time in previous versions of Django, but that isn't true any longer.
    1313
    1414One could argue for keeping this code in case future versions of Django introduce MySQL-version-dependent code that's evaluated at compile time, but in general, unnecessary code hurts maintainability.
Back to Top