Opened 12 years ago
Closed 12 years ago
#17732 closed Uncategorized (fixed)
Add "ensure cookies are enabled" message to CSRF verification failed view
| Reported by: | h3 | Owned by: | nobody |
|---|---|---|---|
| Component: | Uncategorized | Version: | 1.3 |
| Severity: | Normal | Keywords: | |
| Cc: | Triage Stage: | Accepted | |
| Has patch: | yes | Needs documentation: | no |
| Needs tests: | no | Patch needs improvement: | no |
| Easy pickings: | no | UI/UX: | no |
Description
This is a follow up ticket for this discussion:
Sorry for the late response .. been quite busy.
Patch is include, with bonus screenshot: http://i.imgur.com/dyYSm.png
Attachments (2)
Change History (4)
by , 12 years ago
| Attachment: | django-csrf-missing-help-cookies.patch added |
|---|
by , 12 years ago
| Attachment: | django-csrf-missing-help-cookies-view.patch added |
|---|
comment:1 by , 12 years ago
I'd like to get these fixed, but your provided patch doesn't even pass the existing test suite... I did commit the additional error message.
comment:2 by , 12 years ago
| Resolution: | → fixed |
|---|---|
| Status: | new → closed |
| Triage Stage: | Unreviewed → Accepted |
I'm going to go ahead and close this ticket, since I've committed the part which can be committed. If you have a way to improve the error message without tying to the session framework, and without changing the existing behavior, please feel free to re-open the ticket with a patch, or discuss it on the mailing list.
Note:
See TracTickets
for help on using tickets.
Patch of the csrf view to serve the correct reason