Changes between Initial Version and Version 1 of Ticket #17715, comment 7


Ignore:
Timestamp:
02/23/2012 01:58:21 PM (3 years ago)
Author:
akaariai
Comment:

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #17715, comment 7

    initial v1  
    1 The changes look good. I can't spot anything obviously broken. A new user going through the tutorial is the best review here.
     1The changes look good. I can't spot anything obviously broken. Although a new user going through the tutorial would be the best review here.
    22
    3 Avoiding the hard timezone issues in the tutorial is a good choice. But as said before, links to documentation explaining these things is needed. In general there are surprisingly hard issues due to Python's implementation of datetimes, and the problems with different databases. In addition, many new users haven't given enough thought to these issues. For example "which day is it now" type issues will surprise users. So, giving users pointers on how to deal with timezone issues as early as possible is good in my opinion.
     3Avoiding the hard timezone issues in the tutorial is a good choice. But as said before, links to documentation explaining these issues is needed. In general there are some confusing issues due to Python's implementation of datetimes, and due to the different behavior of different databases. For example "which day is it now" issues will surprise some users. So, giving users pointers to how to deal with timezone issues as early as possible is good in my opinion.
    44
    55Reiterating my thoughts here, but it would be just wonderful if there was a django.utils.datetime module which would be fully timezone aware when using USE_TZ=True. The common single-timezone setup, where UTC times are used just to dodge issues with DST issues could be handled fully hidden from the user. Use from django.utils import datetime where you used import datetime before. No other changes to tutorial needed. However, this is of course impossible to do for Django 1.4, and might be too hard/laborious to implement ever.
     6
     7(edit: some stupid mistakes removed)
Back to Top