Code

Changes between Initial Version and Version 1 of Ticket #17471, comment 1


Ignore:
Timestamp:
12/27/11 20:32:38 (3 years ago)
Author:
kmtracey
Comment:

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #17471, comment 1

    initial v1  
    33The patch as presented can't be used in Django as is. It re-interprets Django's EMAIL_USE_TLS setting to mean "use an `smtplib.SMTP_SSL` connection". Such a connection doesn't work for servers who implement TLS, not SSL. For example if you use the patched code against GMail's server port 587 you get an exception: SSLError: (1, '_ssl.c:503: error:140770FC:SSL routines:SSL23_GET_SERVER_HELLO:unknown protocol'). So if we were to change the code as is done in the patch, suddenly everyone who had a working config talking to a TLS server would be broken. 
    44 
    5 It seems like what is needed to talk to an SSL-implementing server (like GMail port 465) is yet another option (sigh) to tell the email code to use an `smtplib.SMTP_SSL` connection rather than doing the starttls thing. Note `smtplib.SMTP_SSL` is new in Python 2.6 so we cannot support this new type of email security except when running under Python 2.6. 
     5It seems like what is needed to talk to an SSL-implementing server (like GMail port 465) is yet another option (sigh) to tell the email code to use an `smtplib.SMTP_SSL` connection rather than doing the starttls thing. Note `smtplib.SMTP_SSL` is new in Python 2.6 so we cannot support this new type of email security except when running under Python 2.6 (and higher). 
    66 
    77Changing this to a feature request rather than a bug, and changing the summary to match. It's not a bug if things don't work correctly if they've been misconfigured, and telling Django to use tls against an email server who is expecting ssl and not tls is a misconfiguration. But what we are missing on the Djagno side is apparently any way to do the ssl connection instead of TLS, and if there are common servers that implement only SSL and not TLS then Django likely should support talking to them.