Changes between Initial Version and Version 1 of Ticket #17198, comment 6


Ignore:
Timestamp:
Feb 27, 2012, 4:27:32 AM (13 years ago)
Author:
Julien Phalip

Legend:

Unmodified
Added
Removed
Modified

  • Ticket #17198, comment 6

    initial v1  
    1 The attach patch ensures that 'pk' is systematically used as an ordering field in the changelist. Tests are also added for the related ticket #16819.
     1The attached patch ensures that 'pk' is systematically used as an ordering field in the changelist. Tests are also added for the related ticket #16819.
    22
    3 It breaks an existing test though (`admin_views. AdminViewBasicTest.testChangeListSortingPreserveQuerySetOrdering`), which was added in r16316 to fix #7309. Luke, do you remember the logic for that test? It seems like it expects the default order to be '-pk', so I'd just like to check if it's ok to make it 'pk' instead.
     3It breaks an existing test though (`admin_views.AdminViewBasicTest.testChangeListSortingPreserveQuerySetOrdering`), which was added in r16316 to fix #7309. Luke, do you remember the logic for that test? It seems like it expects the default order to be '-pk', so I'd just like to check if it's ok to make it 'pk' instead.
    44
    55Thanks!
Back to Top