Changes between Initial Version and Version 1 of Ticket #16715, comment 12


Ignore:
Timestamp:
Oct 4, 2011, 3:16:54 PM (13 years ago)
Author:
Sebastian Goll

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #16715, comment 12

    initial v1  
    11@akaariai: Your patch looks good, and I think that unifying the promotion of joins to a single method `promote_joins` makes sense. It might also fix some issues with nested foreign keys that my patch wouldn't catch. One remark, however: on first sight, `promote_joins` doesn't seem to work recursively, i.e. the order in which we pass joins to this method matters (if one join references the other, passing them in in the opposite order might not lead to the desired avalanche of promotion). Is this a problem? Should we re-run the promotion until all join types stabilize, in order to catch such inter-join dependencies?
    22
    3 Also, why do you exclude `auth_permission` and `django_content_type` from promotion? That `if`-statement should at least have a comment explaining the reason for this.
     3~~Also, why do you exclude `auth_permission` and `django_content_type` from promotion? That `if`-statement should at least have a comment explaining the reason for this.~~
     4
     5(Sorry, please ignore that last paragraph, I misread "pass" for "continue". I guess that code was only used by you for debugging.)
Back to Top