Changes between Initial Version and Version 1 of Ticket #16502, comment 24
- Timestamp:
- Sep 6, 2013, 4:14:46 PM (11 years ago)
Legend:
- Unmodified
- Added
- Removed
- Modified
-
Ticket #16502, comment 24
initial v1 1 1 This is all a little convoluted. There is no longer one problem at hand, and a little clarification might be useful. 2 2 3 Bug 1: `get_template_names()` (as defined in `SingleObjectTemplateResponseMixin`) is returning `None`, which is causing Django to throw a `TemplateDoesNotExist`. This should instead throw a `ImproperlyConfigured` error, as it does not have the information to determine the template file to load. This is more eloquently described in #18853 (marked as duplicate to this topic)3 '''Bug 1''': `get_template_names()` (as defined in `SingleObjectTemplateResponseMixin`) is returning `None`, which is causing Django to throw a `TemplateDoesNotExist`. This should instead throw a `ImproperlyConfigured` error, as it does not have the information to determine the template file to load. This is more eloquently described in #18853 (marked as duplicate to this topic) 4 4 5 Bug 2: The `TemplateDoesNotExist` exception is causing the server error message, as detailed (and solved) in #21058.5 '''Bug 2''': The `TemplateDoesNotExist` exception is causing the server error message, as detailed (and solved) in #21058. 6 6 7 Feature Request 1: Creating a CBGV by only overriding the `form_class` variable. The patch provided creates the ability to do so, but does not actually solve the bugs detailed.7 '''Feature Request 1''': Creating a CBGV by only overriding the `form_class` variable. The patch provided creates the ability to do so, but does not actually solve the bugs detailed. 8 8 9 9 I spoke to Russel about the possibility of the new feature. Unfortunately, determining the model based off a form specified in `form_class` is not desirable, because this assumes the form is a ModelForm, which may not be the case. As such, this feature (and patch) will therefore not be approved for Django.