Opened 13 years ago
Last modified 13 years ago
#16465 new New feature
Admin history view should also show history of super-object(s)
Reported by: | Gertjan van Oosten | Owned by: | nobody |
---|---|---|---|
Component: | contrib.admin | Version: | 1.3 |
Severity: | Normal | Keywords: | |
Cc: | Triage Stage: | Accepted | |
Has patch: | yes | Needs documentation: | no |
Needs tests: | no | Patch needs improvement: | yes |
Easy pickings: | no | UI/UX: | yes |
Description
It would be nice if the admin history view for an object would also show the history of its super-object(s) (if your model uses inheritance).
A small and simple patch is attached.
Attachments (1)
Change History (4)
by , 13 years ago
Attachment: | admin-history_view.patch added |
---|
comment:1 by , 13 years ago
Patch needs improvement: | set |
---|---|
Triage Stage: | Unreviewed → Design decision needed |
UI/UX: | set |
comment:2 by , 13 years ago
Agreed on most of you comments. Like I said: the patch is small and simple. :-)
Also, it fits the only real-world use case I have for this, which is editing of the lowest level of subclass in the hierarchy (everything above is disabled). So quite possibly some more input is needed to see if there are other use cases and the approach needs to be generalised.
comment:3 by , 13 years ago
Triage Stage: | Design decision needed → Accepted |
---|
The UI here is actually the big problem, I think: how do you represent the concept of a "parent" object in a way that makes sense to the *users* of the admin? Nevertheless, this is a good idea which improves the overall usability of the admin. So if we can figure out how to successfully present the information let's do it.
I'm not a fan of the approach in the attached patch, but I think that the general idea is worth considering. Similarly, it could be considered that the changes made in the child model which are relevant to the parent model would be displayed in the parent model's history. Some design discussion needs to take place around what the user's expectations would be, if it'd be worth improving the interface to highlight the changes made via a different model, etc.