Changes between Initial Version and Version 1 of Ticket #16368, comment 16


Ignore:
Timestamp:
Jul 29, 2011, 5:31:56 PM (13 years ago)
Author:
Ramiro Morales

Legend:

Unmodified
Added
Removed
Modified

  • Ticket #16368, comment 16

    initial v1  
    77I don't think the changes from that commit in particular are wrong regarding this issue. Looking at the traceback in comment:12 IMHO what's the culprit of this unexpected behavior is the fact that `django.contrib.contenttypes.generic` contains both the definitions of the model-related generic stuff (!GenericForeignKey, etc.) AND the admin app-related specialized inlines (!GenericInlineModelAdmin, !GenericStackedInline, !GenericTabularInline.)
    88
    9 So, for example, if you import `django.contrib.contenttypes.generic` from your `models.py` because you need !GenericForeignKey then the Generic*Inline* sutff imports `django.contrib.admin` and it in its own turn imports `contrib.sites` causing the observed failure. Again, the Sites framework isn't listed in INSTALLED_APPS and what is worth: The admin app isn't either (!).
     9So, for example, if you import `django.contrib.contenttypes.generic` from your `models.py` because you need !GenericForeignKey then the Generic*Inline* sutff imports `django.contrib.admin` and it in its own turn imports `contrib.sites` causing the observed failure. Again, the Sites framework isn't listed in INSTALLED_APPS and what is worse: The admin app isn't either (!).
    1010
    11 Maybe it's time we move !GenericInlineModelAdmin, !GenericStackedInline, !GenericTabularInline from `django.contrib.contenttypes.generic` to, say, `django.contrib.contenttypes.generic_admin`? (of course this would need a deprecation path)
     11Maybe it's time we move !GenericInlineModelAdmin, !GenericStackedInline, !GenericTabularInline from `django.contrib.contenttypes.generic` to, say, `django.contrib.contenttypes.generic_admin`? (of course this would need a deprecation process)
Back to Top