Opened 14 years ago

Last modified 13 years ago

#16031 closed Cleanup/optimization

Custom comment form is incomplete and wrong. — at Version 1

Reported by: ddshore@… Owned by: nobody
Component: Documentation Version: 1.3
Severity: Normal Keywords:
Cc: Daniel Quinn Triage Stage: Ready for checkin
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: yes UI/UX: no

Description (last modified by Gabriel Hurley)

When viewing the documentation for the django comment framework (​http://docs.djangoproject.com/en/dev/ref/contrib/comments/) this is the example form that is shown:

{% get_comment_form for event as form %}
<form action="{% comment_form_target %}" method="post">
  {{ form }}
  <tr>
    <td></td>
    <td><input type="submit" name="preview" class="submit-post" value="Preview"></td>
  </tr>
</form>

However, the post button is missing, only the preview button appears, and it's class is shown as a post button. Not sure what the original intention was, but it would probably be better to have both buttons in the documentation: 

	<input type = "submit" name = "post" class = "submit-post" value = "post">
	<input type = "submit" name = "preview" class = "submit-preview" value = "preview">

or at least correct the class for the preview button to submit-preview instead of submit-post.

Change History (2)

comment:1 by Gabriel Hurley, 14 years ago

Description: modified (diff)
Easy pickings: set
Triage Stage: Unreviewed → Accepted

Agreed. There are definitely some mixed signals in that example. Might as well include both buttons for completeness.

Speaking of "preview" buttons, you might want to use Trac's preview to check your code formatting before submitting your ticket next time. ;-)

by teraom, 14 years ago

Attachment: custom_comment_form-16031.diff​ added
Note: See TracTickets for help on using tickets.
Back to Top