Changes between Initial Version and Version 1 of Ticket #15053, comment 32


Ignore:
Timestamp:
Dec 6, 2013, 8:41:12 AM (10 years ago)
Author:
Unai Zalakain

Legend:

Unmodified
Added
Removed
Modified

  • Ticket #15053, comment 32

    initial v1  
    66 making it easier to reuse it.
    77
    8 - The cache loader needs to be able to specify the loaders to try in
    9  `find_template`. So we appended just an other parameter to `find_template`
    10  making them to: `skip_template` and `loaders`.
    11 
    12  I noticed that the only thing that `skip_template` is useful for is for
    13  skipping loaders. So we could squash those two parameters into a single one:
    14  `loaders`. If that parameter isn't given the global loaders are loaded.
    15 
    16  The loader skipping could be done outside `find_template`: in
    17  `get_template` so this last function is the one that now gets the template
    18  to skip.
    19 
    208- I've also added the `skip_template` parameter to the `select_template`
    219 function for the cohesion.
    … …  
    2311- Docs has been updated (only documented functions are `get_template` and
    2412 `skip_template`.
    25 
    26 @goinnn As a consequence of all this changes, you must first filter the cached
    27 loaders through `skip_loaders` and then pass them to `find_template`. This
    28 is an extra line of code but I think it enhances clarity. Before I forget it,
    29 we must update the docs that refer to loaders and tell about the new
    30 `never_skip` and `use_skip_template` attributes (I'd be glad to help with
    31 that if needed).
    3213
    3314Currently, the cache test fails (that's good), check that that they pass
Back to Top