Changes between Initial Version and Version 1 of Ticket #15018


Ignore:
Timestamp:
01/05/2011 07:49:40 AM (5 years ago)
Author:
russellm
Comment:

Your point 3 doesn't make any sense, and I can't work out what it might be a typo for.

If you want to prove there is a problem here, write a formal test case. There are existing tests for LimitedStream covering a wide range of potential use cases; if you can encode your use case as a test that fails, please provide that test and reopen.

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #15018

    • Property Status changed from new to closed
    • Property Patch needs improvement unset
    • Property Needs tests unset
    • Property Needs documentation unset
    • Property Resolution changed from to worksforme
  • Ticket #15018 – Description

    initial v1  
    11I read the code at (http://code.djangoproject.com/browser/django/trunk/django/core/handlers/wsgi.py), LimitedStream.readline function maybe go wrong when the situation meet criteria below:
    2 <1> '\n' not in self.buffer
    3 <2> and size is not None
    4 <3> and len(self.buffer) > len(self.buffer)
     2 1. '\n' not in self.buffer
     3 2. and size is not None
     4 3. and len(self.buffer) > len(self.buffer)
    55it will go to ln102, and leads the parameter of LimitedStream._read_limited is negative, and it will be bypassed to ln82.
    66I don't read the implementation of self.stream.read, so i'm not sure if it will cause damage.
Back to Top