Code

Changes between Initial Version and Version 1 of Ticket #14930, comment 16


Ignore:
Timestamp:
10/03/12 04:57:08 (19 months ago)
Author:
vicould
Comment:

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #14930, comment 16

    initial v1  
    1 Yes you're right, I just tested without the patch and the tests I wrote failed. But with the patch, and the {{{order_by}}} argument inside the {{{extra}}} instead of as an additional call the test for {{{values_list}}} pass. However, the test with the {{{values}}} fails, as the additional ordering column is inserted in the list. 
    2 Here is the output of the test: 
     1Yes you're right, I just tested without the patch and the tests I wrote failed. With the patch and the {{{order_by}}} argument inside the {{{extra}}} instead of as an additional call, the test for {{{values_list}}} passes. 
     2However, the test with the {{{values}}} fails, as the additional ordering column is inserted in the list. Here is the output of the test: 
    33{{{ 
    44First differing element 0: 
     
    66{u'num': 72} 
    77}}} 
    8 I tested with two extra columns, and only the one on which the results are sorted is inserted in the values list. I will try to find the cause, but it seems related to the {{{order_by}}} argument. 
     8I tested with two extra columns, and only the one on which the results are sorted is inserted in the values list. I will try to find the cause and improve the patch, it seems related to the {{{order_by}}} argument.