Changes between Initial Version and Version 1 of Ticket #14549, comment 7
- Timestamp:
- Feb 17, 2014, 12:02:15 AM (10 years ago)
Legend:
- Unmodified
- Added
- Removed
- Modified
-
Ticket #14549, comment 7
initial v1 4 4 5 5 - The `through_` prefix makes it obvious it's an option that is only available to custom `through` relations. 6 - IMO what is "source" and "target" doesn't always make sense for M2M (i.e. `symmetrical` and relations to `self`). In that respect, I would document it as `through_fields=('<field1>', '<field2>')` and leave the concept of "source" and "target" out of the equation.6 - IMO what is "source" and "target" doesn't always make sense for M2M (i.e. anything other than `symmetrical` and relations to `self`). In that respect, I would document it as `through_fields=('<field1>', '<field2>')` and leave the concept of "source" and "target" out of the equation (with a special note for `symmetrical=False`). 7 7 - I prefer being fully explicit, rather than having a fallback mechanism for only one of the FK. 8 8 9 9 @dfunckt, would you mind integrating your tests directly in the Django test suite (probably in `django/tests/many_to_many/tests.py`) rather than in a separate test project? Also it would be helpful if you made a github feature branch against Django's master (https://docs.djangoproject.com/en/dev/internals/contributing/writing-code/working-with-git/), that would facilitate the review process. 10 11 Edit: Reworded confusing point regarding "source" and "target".