Rss201rev2Feed bug

[ZalivinDenis@…]

Bug with ...

Even exhample, given here is not working:

>>> from django.utils import feedgenerator
>>> feed = feedgenerator.Rss201rev2Feed(
...     title=u"Poynter E-Media Tidbits",
...     link=u"http://www.poynter.org/column.asp?id=31",
...     description=u"A group weblog by the sharpest minds in online media/journalism/publishing.",
...     language=u"en",
... )
>>> feed.add_item(
...     title="Hello",
...     link=u"http://www.holovaty.com/test/",
...     description="Testing."
... )
>>> fp = open('test.rss', 'w')
>>> feed.write(fp, 'utf-8')

/home/denis/svn/trunk/env/django121/django/utils/feedgenerator.pyc in write(self, outfile, encoding)
    201         handler.startElement(u"rss", self.rss_attributes())
    202         handler.startElement(u"channel", self.root_attributes())
--> 203         self.add_root_elements(handler)
    204         self.write_items(handler)
    205         self.endChannelElement(handler)

/home/denis/svn/trunk/env/django121/django/utils/feedgenerator.pyc in add_root_elements(self, handler)
    220         handler.addQuickElement(u"link", self.feed['link'])
    221         handler.addQuickElement(u"description", self.feed['description'])
--> 222         handler.addQuickElement(u"atom:link", None, {u"rel": u"self", u"href": self.feed['feed_url']})
    223         if self.feed['language'] is not None:
    224             handler.addQuickElement(u"language", self.feed['language'])

/home/denis/svn/trunk/env/django121/django/utils/xmlutils.py in addQuickElement(self, name, contents, attrs)
     10         print '>>>>>>>>>>', attrs
     11         if attrs is None: attrs = {}
---> 12         self.startElement(name, attrs)
     13         if contents is not None:
     14             self.characters(contents)

/usr/lib/python2.5/xml/sax/saxutils.pyc in startElement(self, name, attrs)
    130         self._write('<' + name)
    131         for (name, value) in attrs.items():
--> 132             self._write(' %s=%s' % (name, quoteattr(value)))
    133         self._write('>')
    134 

/usr/lib/python2.5/xml/sax/saxutils.pyc in quoteattr(data, entities)
     71     entities = entities.copy()
     72     entities.update({'\n': '&#10;', '\r': '&#13;', '\t':'&#9;'})
---> 73     data = escape(data, entities)
     74     if '"' in data:
     75         if "'" in data:

/usr/lib/python2.5/xml/sax/saxutils.pyc in escape(data, entities)
     37 
     38     # must do ampersand first
---> 39     data = data.replace("&", "&amp;")
     40     data = data.replace(">", "&gt;")
     41     data = data.replace("<", "&lt;")

AttributeError: 'NoneType' object has no attribute 'replace'

[anonymous]

10         print '>>>>>>>>>>', attrs

This is my debug string.

self.feedfeed_url is None here:

--> 222         handler.addQuickElement(u"atom:link", None, {u"rel": u"self", u"href": self.feed['feed_url']})

[Fabian Topfstedt]

Reproducing the bug and that feed_url property is causing it

[Fabian Topfstedt]

The patch to make it work (against trunk)

[Fabian Topfstedt]

Regression test to prove that the patch fixes the problem

[Fabian Topfstedt]

The bug actually concerned django.utils.feedgenerators.RssFeed (which Rss201rev2Feed inherits from). I patched it so that RssFeeds without a feed_url do not render the "atom:link" attribute which is not required by RSS (see ​http://bit.ly/bAZpKT) and wrote a regression test.

[Fabian Topfstedt]

It's an obvious bug and (sticking to the docs) I bypass the ticket triangers and accept it.

[anonymous]

Does anyone know why this ticket (being accepted) is not in trunk?

[Łukasz Rekucki]

Maybe, because it doesn't have a trunk ready patch which someone can review ?

The patch should include both the fix and unit tests integrated into Django's test suite. The tests are already there, they just need to be put into the right place.

[Taylor Mitchell]

Patch incorporating code and tests, applies cleanly to trunk

[anonymous]

why is this still not fixed ? in 1.2.7 ? or even in 1.3.1 ?

[Aymeric Augustin]

Since this isn't a major problem, per the backport policy, it is going to be fixed on trunk only, not in the stable banches.

I'm going to commit the fix.

[Aymeric Augustin]

In [17029]:

Fixed #14202 -- made the atom:link element optional in feeds.