Changes between Initial Version and Version 1 of Ticket #13696, comment 16
- Timestamp:
- Jan 14, 2012, 9:23:27 PM (13 years ago)
Legend:
- Unmodified
- Added
- Removed
- Modified
-
Ticket #13696, comment 16
initial v1 1 The note in this comment: https://code.djangoproject.com/browser/django/trunk/django/forms/models.py?rev=17373#L637 seems to indicate that !AutoField's ''editable'' value isn't False so I don't think this patch is ready for commit. The condition in the ''if'' test would need to be a bit more complex than the two proposed so far: Checking for the field being a PK field (as implemented in the patch) or checking ofit being a PK and not editable.1 The note in this comment: https://code.djangoproject.com/browser/django/trunk/django/forms/models.py?rev=17373#L637 seems to indicate that !AutoField's ''editable'' value isn't False so I don't think this patch is ready for commit. The condition in the ''if'' test would need to be a bit more complex than the two proposed so far: Checking for the field being a PK field (as implemented in the patch) or checking for it being a PK and not editable.